fix: decode userState in parseState for code flow#1507
Open
earshinov wants to merge 1 commit into
Open
Conversation
The library encodes userState when composing the OAuth state parameter, but parseState returned the extracted value without decoding it. In the authorization-code callback path, the query parser only decodes the returned state once, leaving userState still encoded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library encodes
userStatewhen composing the OAuth state parameter, butparseStatereturned the extracted value without decoding it. In the authorization-code callback path, the query parser only decodes the returned state once, leavinguserStatestill encoded.Fixes #783, #1506
Worth noting: this was already fixed once in #61 (2017), which added
decodeURIComponent(parts["state"])on the return path. That decode was later dropped during the workspace rewrite. When nonce-packing +parseStatewere introduced afterwards the extracteduserStatewas returned undecoded again.